From: Erez_Zadok <ezk@cs.sunysb.edu>
Date: Mon, 30 Apr 2007 20:42:30 +0000 (-0400)
Subject: branch management: disallow setting leftmost branch to readonly
X-Git-Tag: unionfs-2.1.1~139
X-Git-Url: https://git.fsl.cs.stonybrook.edu/?a=commitdiff_plain;h=da59055cc0ca7ba2252189fc23f7794bea7a499c;p=unionfs-2.6.26.y.git

branch management: disallow setting leftmost branch to readonly

Unionfs requires the leftmost branch to be writeable for copyup to work
properly and simply.  If, through branch-management commands (add, delete,
or mode change), the leftmost branch will becomes readonly, then return an
error (and tell the user to use "remount,ro" if they want a readonly union).
---

diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c
index 10520c0fbf3..3a8d74c5395 100644
--- a/fs/unionfs/super.c
+++ b/fs/unionfs/super.c
@@ -626,12 +626,20 @@ static int unionfs_remount_fs(struct super_block *sb, int *flags,
 out_no_change:
 
 	/******************************************************************
-	 * WE'RE ALMOST DONE: see if we need to allocate a small-sized new
-	 * vector, copy the vectors to their correct place, release the
-	 * refcnt of the older ones, and return.
-	 * Also handle invalidating any pages that will have to be re-read.
+	 * WE'RE ALMOST DONE: check if leftmost branch might be read-only,
+	 * see if we need to allocate a small-sized new vector, copy the
+	 * vectors to their correct place, release the refcnt of the older
+	 * ones, and return.  Also handle invalidating any pages that will
+	 * have to be re-read.
 	 *******************************************************************/
 
+	if (!(tmp_data[0].branchperms & MAY_WRITE)) {
+		printk("unionfs: leftmost branch cannot be read-only "
+		       "(use \"remount,ro\" to create a read-only union)\n");
+		err = -EINVAL;
+		goto out_release;
+	}
+
 	/*
 	 * Allocate space for actual pointers, if needed.  By the time we
 	 * finish this block of code, new_branches and new_lower_paths will