ARM: OMAP2+: Fix refcount leak in omap_gic_of_init
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 9 Mar 2022 10:43:01 +0000 (10:43 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 May 2022 10:14:55 +0000 (12:14 +0200)
[ Upstream commit 0f83e6b4161617014017a694888dd8743f46f071 ]

The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.

Fixes: fd1c07861491 ("ARM: OMAP4: Fix the init code to have OMAP4460 errata available in DT build")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Message-Id: <20220309104302.18398-1-linmq006@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/mach-omap2/omap4-common.c

index e5dcbda20129dab7a723154a18885fb3ee6c1b44..7fff67ea7bcd3ec87c11c724bb737d7bd34ab784 100644 (file)
@@ -342,10 +342,12 @@ void __init omap_gic_of_init(void)
 
        np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
        gic_dist_base_addr = of_iomap(np, 0);
+       of_node_put(np);
        WARN_ON(!gic_dist_base_addr);
 
        np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-twd-timer");
        twd_base = of_iomap(np, 0);
+       of_node_put(np);
        WARN_ON(!twd_base);
 
 skip_errata_init: