don't check for NULL before XFREE

strdup -> xstrdup

diff --git a/amd/amfs_nfsx.c b/amd/amfs_nfsx.c
index 4f276f017d66856c6d44068ceae07b1dc82d0ad8..00f9b7567fc768aaf06019580a81fb8ac7016507 100644 (file)
--- a/amd/amfs_nfsx.c
+++ b/amd/amfs_nfsx.c
@@ -195,7 +195,10 @@ amfs_nfsx_init(mntfs *mf)
     char *pref;
     int error = 0;
 
-    info = strdup(mf->mf_info);
+    info = xstrdup(mf->mf_info);
+    if (info == NULL)
+      return errno;
+
     host = strchr(info, ':');
     if (!host) {
       error = EINVAL;
@@ -251,18 +254,14 @@ amfs_nfsx_init(mntfs *mf)
        /* propagate the on_autofs flag */
        nx->nx_v[i].n_mnt->mf_flags |= mf->mf_flags & MFF_ON_AUTOFS;
       }
-      if (rfs)
-       XFREE(rfs);
-      if (mp)
-       XFREE(mp);
-      if (xinfo)
-       XFREE(xinfo);
+      XFREE(rfs);
+      XFREE(mp);
+      XFREE(xinfo);
     }
 
     XFREE(ivec);
   errexit:
-    if (info)
-      XFREE(info);
+    XFREE(info);
     if (error)
       return error;
   }