hypfs: Fix error number left in struct pointer member
authorDavid Howells <dhowells@redhat.com>
Thu, 21 Mar 2019 10:08:08 +0000 (10:08 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 16:59:35 +0000 (18:59 +0200)
commitef1bb2f3c68c6a2262b6a66c57a2ab477b68e34f
treea9ce6cc6b5d8480772c30348a381eb5676ccc8ca
parent86fa1c1b3ab11e0a891f301c041c152a2add35e1
hypfs: Fix error number left in struct pointer member

[ Upstream commit b54c64f7adeb241423cd46598f458b5486b0375e ]

In hypfs_fill_super(), if hypfs_create_update_file() fails,
sbi->update_file is left holding an error number.  This is passed to
hypfs_kill_super() which doesn't check for this.

Fix this by not setting sbi->update_value until after we've checked for
error.

Fixes: 24bbb1faf3f0 ("[PATCH] s390_hypfs filesystem")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
cc: Heiko Carstens <heiko.carstens@de.ibm.com>
cc: linux-s390@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/s390/hypfs/inode.c