Unionfs: better error handling in rename code when copyups are involved
authorErez_Zadok <ezk@cs.sunysb.edu>
Tue, 10 Jul 2007 00:14:41 +0000 (20:14 -0400)
committerErez Zadok <ezk@cs.sunysb.edu>
Tue, 13 Jan 2009 01:43:14 +0000 (20:43 -0500)
commitbbac77262283bea097cc18152666fff28509af60
treefb0a9ecc7657afa03fea59067f5b9a8848e9cb16
parent4f1afbb41d653901da727c87369a4bc706f46a75
Unionfs: better error handling in rename code when copyups are involved

First, rewrite code slightly and document it better to explain why we appear
to ignore copyup errors (because we try the next branch to the left).

Second, change a BUG_ON to a printk(KERN_ERR), because a mild failure to
copyup a file should not cause an oops.  For example, some file systems
don't support UIDs/GIDs (e.g., VFAT) and others don't allow you to chmod a
symlink (e.g., jffs2), possibly resulting in mild copyup failures; that
shouldn't be considered so severe as to cause an oops.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
fs/unionfs/rename.c