media: atmel: atmel-isc: fix INIT_WORK misplacement
authorEugen Hristev <eugen.hristev@microchip.com>
Fri, 12 Apr 2019 10:19:46 +0000 (06:19 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2019 14:38:14 +0000 (15:38 +0100)
commitb6a10a40a4f8e5cdaaafc85bdd7e4113223a07ba
tree76d33fb48e91131f01bb9e06e9d48066764b7ce1
parent2c4575f07080c2ccefa0a5bef1753a2c7d6ed258
media: atmel: atmel-isc: fix INIT_WORK misplacement

commit 79199002db5c571e335131856b3ff057ffd9f3c0 upstream.

In case the completion function failes, unbind will be called
which will call cancel_work for awb_work.
This will trigger a WARN message from the workqueue.
To avoid this, move the INIT_WORK call at the start of the completion
function. This way the work is always initialized, which corresponds
to the 'always canceled' unbind code.

Fixes: 93d4a26c3d ("[media] atmel-isc: add the isc pipeline function")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/atmel/atmel-isc.c