Bluetooth: 6lowpan: Fix memory corruption of ipv6 destination address
authorGlenn Ruben Bakke <glennrubenbakke@nordicsemi.no>
Fri, 22 Apr 2016 16:06:11 +0000 (18:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Jun 2016 01:18:52 +0000 (18:18 -0700)
commitaa3f5dcc7e6eba318010d1397f80077a69d73d60
tree11b09056539b308a294da291a24eac730d982904
parent5f5dd28b3159de16b1995e4c0e93a6af7d3d18ea
Bluetooth: 6lowpan: Fix memory corruption of ipv6 destination address

commit 55441070ca1cbd47ce1ad2959bbf4b47aed9b83b upstream.

The memcpy of ipv6 header destination address to the skb control block
(sbk->cb) in header_create() results in currupted memory when bt_xmit()
is issued. The skb->cb is "released" in the return of header_create()
making room for lower layer to minipulate the skb->cb.

The value retrieved in bt_xmit is not persistent across header creation
and sending, and the lower layer will overwrite portions of skb->cb,
making the copied destination address wrong.

The memory corruption will lead to non-working multicast as the first 4
bytes of the copied destination address is replaced by a value that
resolves into a non-multicast prefix.

This fix removes the dependency on the skb control block between header
creation and send, by moving the destination address memcpy to the send
function path (setup_create, which is called from bt_xmit).

Signed-off-by: Glenn Ruben Bakke <glenn.ruben.bakke@nordicsemi.no>
Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/bluetooth/6lowpan.c