net-sysfs: Call dev_hold always in netdev_queue_add_kobject
authorJouni Hogander <jouni.hogander@unikie.com>
Thu, 5 Dec 2019 13:57:07 +0000 (15:57 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 11 Jun 2020 18:05:37 +0000 (19:05 +0100)
commita7750e90935c481ba6188fb282d87a3368cfcfac
tree9fa5410547e04a0f7bd73035981fddd2e397eddd
parent6b07736e72bc1546400d085485d92c256408c5ea
net-sysfs: Call dev_hold always in netdev_queue_add_kobject

commit e0b60903b434a7ee21ba8d8659f207ed84101e89 upstream.

Dev_hold has to be called always in netdev_queue_add_kobject.
Otherwise usage count drops below 0 in case of failure in
kobject_init_and_add.

Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
Reported-by: Hulk Robot <hulkci@huawei.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: David Miller <davem@davemloft.net>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/core/net-sysfs.c