v4l: vsp1: Fix crash when resetting pipeline
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Wed, 18 May 2016 23:01:21 +0000 (20:01 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Oct 2016 13:21:23 +0000 (15:21 +0200)
commit5df20b95ea7ca7b4cfb1705eee95f53d19597065
treed0011e822677e8b164e9990b86612571411ed134
parent58ae1d53c880ddac8f408d848c1f64760834c770
v4l: vsp1: Fix crash when resetting pipeline

commit d69e40fade97b6b19837c1772efa516bc28cc870 upstream.

The vsp1_pipeline_reset() function loops over pipeline inputs and output
and resets them. When doing so it assumes both that the pipeline has
been correctly configured with an output, and that inputs are are stored
in the pipe inputs array at positions 0 to num_inputs-1.

Both the assumptions are incorrect. The pipeline might need to be reset
after a failed attempts to configure it, without any output specified.
Furthermore, inputs are stored in a positiong equal to their RPF index,
possibly creating holes in the inputs array if the RPFs are not used in
sequence.

Fix both issues by looping over the whole inputs array and skipping
unused entries, and ignoring the output when not set.

Fixes: ff7e97c94d9f ("[media] v4l: vsp1: Store pipeline pointer in rwpf")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/vsp1/vsp1_pipe.c