mmc: sdhci: Do not disable interrupts while waiting for clock
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 20 Mar 2017 17:50:29 +0000 (19:50 +0200)
committerJiri Slaby <jslaby@suse.cz>
Fri, 7 Apr 2017 08:38:27 +0000 (10:38 +0200)
commit597590a08a087c2d795a840283203c4a431ea080
treeaad5fe51ec21992deb1a67d5ca05d9727895e035
parentb9c5e82056e442717f4ec14c1d9248bc99f66a80
mmc: sdhci: Do not disable interrupts while waiting for clock

commit e2ebfb2142acefecc2496e71360f50d25726040b upstream.

Disabling interrupts for even a millisecond can cause problems for some
devices. That can happen when sdhci changes clock frequency because it
waits for the clock to become stable under a spin lock.

The spin lock is not necessary here. Anything that is racing with changes
to the I/O state is already broken. The mmc core already provides
synchronization via "claiming" the host.

Although the spin lock probably should be removed from the code paths that
lead to this point, such a patch would touch too much code to be suitable
for stable trees. Consequently, for this patch, just drop the spin lock
while waiting.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/mmc/host/sdhci.c