ovl: Copy up underlying inode's ->i_mode to overlay inode
authorVivek Goyal <vgoyal@redhat.com>
Fri, 1 Jul 2016 20:34:25 +0000 (16:34 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Jul 2016 15:42:23 +0000 (08:42 -0700)
commit4289e00c9a26e9718b586fc49ec1bf5959e6bef3
tree2615c882955a2d1f94dd09ad03cea68f0a22c233
parenta7ed367c5cf3d455b8c3b85b2f6c222f01dddea1
ovl: Copy up underlying inode's ->i_mode to overlay inode

commit 07a2daab49c549a37b5b744cbebb6e3f445f12bc upstream.

Right now when a new overlay inode is created, we initialize overlay
inode's ->i_mode from underlying inode ->i_mode but we retain only
file type bits (S_IFMT) and discard permission bits.

This patch changes it and retains permission bits too. This should allow
overlay to do permission checks on overlay inode itself in task context.

[SzM] It also fixes clearing suid/sgid bits on write.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Reported-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/overlayfs/inode.c
fs/overlayfs/overlayfs.h