scsi: sg: fix SG_DXFER_FROM_DEV transfers
authorJohannes Thumshirn <jthumshirn@suse.de>
Fri, 7 Jul 2017 08:56:38 +0000 (10:56 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 11 Jun 2020 18:05:49 +0000 (19:05 +0100)
commit341068a66ab680ab19b4938253b872ca00ec8121
tree1c3466e399dee233e43b4284fdd0272247c9960a
parent8d1f3b474a89b42f957ba3bae959dd3cd16531ca
scsi: sg: fix SG_DXFER_FROM_DEV transfers

commit 68c59fcea1f2c6a54c62aa896cc623c1b5bc9b47 upstream.

SG_DXFER_FROM_DEV transfers do not necessarily have a dxferp as we set
it to NULL for the old sg_io read/write interface, but must have a
length bigger than 0. This fixes a regression introduced by commit
28676d869bbb ("scsi: sg: check for valid direction before starting the
request")

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Fixes: 28676d869bbb ("scsi: sg: check for valid direction before starting the request")
Reported-by: Chris Clayton <chris2553@googlemail.com>
Tested-by: Chris Clayton <chris2553@googlemail.com>
Cc: Douglas Gilbert <dgilbert@interlog.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Chris Clayton <chris2553@googlemail.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Cristian Crinteanu <crinteanu.cristian@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/scsi/sg.c