netfilter: nfnetlink: Improve input length sanitization in nfnetlink_rcv
authorMateusz Jurczyk <mjurczyk@google.com>
Wed, 7 Jun 2017 13:50:38 +0000 (15:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Aug 2017 08:26:40 +0000 (10:26 +0200)
commit1eb33a1b89e107d103d43d4ee757e31cfd5c832c
treece99e6f9d0b74d3cc7d3964764a0e4efa71444ba
parent8b5041077024eca607ae21d90186110452241668
netfilter: nfnetlink: Improve input length sanitization in nfnetlink_rcv

commit f55ce7b024090a51382ccab2730b96e2f7b4e9cf upstream.

Verify that the length of the socket buffer is sufficient to cover the
nlmsghdr structure before accessing the nlh->nlmsg_len field for further
input sanitization. If the client only supplies 1-3 bytes of data in
sk_buff, then nlh->nlmsg_len remains partially uninitialized and
contains leftover memory from the corresponding kernel allocation.
Operating on such data may result in indeterminate evaluation of the
nlmsg_len < NLMSG_HDRLEN expression.

The bug was discovered by a runtime instrumentation designed to detect
use of uninitialized memory in the kernel. The patch prevents this and
other similar tools (e.g. KMSAN) from flagging this behavior in the future.

Signed-off-by: Mateusz Jurczyk <mjurczyk@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nfnetlink.c