slcan: Don't transmit uninitialized stack data in padding
authorRichard Palethorpe <rpalethorpe@suse.com>
Wed, 1 Apr 2020 10:06:39 +0000 (12:06 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 28 Apr 2020 18:03:51 +0000 (19:03 +0100)
commit08fadc32ce6239dc75fd5e869590e29bc62bbc28
tree9c707a7457033ab244c1c00d51629c56257ac058
parent596ba660d5c010ca8c3f9e3f60d530423593bee7
slcan: Don't transmit uninitialized stack data in padding

commit b9258a2cece4ec1f020715fe3554bc2e360f6264 upstream.

struct can_frame contains some padding which is not explicitly zeroed in
slc_bump. This uninitialized data will then be transmitted if the stack
initialization hardening feature is not enabled (CONFIG_INIT_STACK_ALL).

This commit just zeroes the whole struct including the padding.

Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
Fixes: a1044e36e457 ("can: add slcan driver for serial/USB-serial CAN adapters")
Reviewed-by: Kees Cook <keescook@chromium.org>
Cc: linux-can@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: security@kernel.org
Cc: wg@grandegger.com
Cc: mkl@pengutronix.de
Cc: davem@davemloft.net
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/can/slcan.c